summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2017-06-23 18:17:38 +0300
committerBen Hutchings <ben@decadent.org.uk>2017-10-12 15:27:55 +0100
commiteb1472fe74a9aa9f9de48212976839b473739e95 (patch)
treea1c87d024fd8e9e8cc8535f8e1a1802abef40cc3
parenta31c633387c9a2adb11fd3e2e2bcf43ef3759067 (diff)
downloadlinux-stable-eb1472fe74a9aa9f9de48212976839b473739e95.tar.gz
linux-stable-eb1472fe74a9aa9f9de48212976839b473739e95.tar.bz2
linux-stable-eb1472fe74a9aa9f9de48212976839b473739e95.zip
libertas: Fix lbs_prb_rsp_limit_set()
commit 69551f5f370cc20342fab17ca54716b6ec7e332d upstream. The kstrtoul() test was reversed so this always returned -ENOTSUPP. Fixes: 27d7f47756f4 ("net: wireless: replace strict_strtoul() with kstrtoul()") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: James Cameron <quozl@laptop.org> Signed-off-by: Kalle Valo <kvalo@codeaurora.org> [bwh: Backported to 3.16: adjust filename] Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
-rw-r--r--drivers/net/wireless/libertas/mesh.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/net/wireless/libertas/mesh.c b/drivers/net/wireless/libertas/mesh.c
index 6fef746345bc..99da58e99082 100644
--- a/drivers/net/wireless/libertas/mesh.c
+++ b/drivers/net/wireless/libertas/mesh.c
@@ -240,8 +240,9 @@ static ssize_t lbs_prb_rsp_limit_set(struct device *dev,
memset(&mesh_access, 0, sizeof(mesh_access));
mesh_access.data[0] = cpu_to_le32(CMD_ACT_SET);
- if (!kstrtoul(buf, 10, &retry_limit))
- return -ENOTSUPP;
+ ret = kstrtoul(buf, 10, &retry_limit);
+ if (ret)
+ return ret;
if (retry_limit > 15)
return -ENOTSUPP;