diff options
| author | Bart Van Assche <bart.vanassche@sandisk.com> | 2016-11-21 10:21:41 -0800 |
|---|---|---|
| committer | Sasha Levin <alexander.levin@verizon.com> | 2017-01-15 09:49:52 -0500 |
| commit | 8dcd21b372737c2e75d9f60807573067d01c895f (patch) | |
| tree | 83d9f52044541ccab86408b9656d527d0a92e88c | |
| parent | 9cdff4fe5279dc07351ecdd77a89db5ed6bba9af (diff) | |
| download | linux-stable-8dcd21b372737c2e75d9f60807573067d01c895f.tar.gz linux-stable-8dcd21b372737c2e75d9f60807573067d01c895f.tar.bz2 linux-stable-8dcd21b372737c2e75d9f60807573067d01c895f.zip | |
IPoIB: Avoid reading an uninitialized member variable
[ Upstream commit 11b642b84e8c43e8597de031678d15c08dd057bc ]
This patch avoids that Coverity reports the following:
Using uninitialized value port_attr.state when calling printk
Fixes: commit 94232d9ce817 ("IPoIB: Start multicast join process only on active ports")
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: Erez Shitrit <erezsh@mellanox.com>
Cc: <stable@vger.kernel.org>
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
| -rw-r--r-- | drivers/infiniband/ulp/ipoib/ipoib_multicast.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_multicast.c b/drivers/infiniband/ulp/ipoib/ipoib_multicast.c index ffb83b5f7e80..6391ed0fe449 100644 --- a/drivers/infiniband/ulp/ipoib/ipoib_multicast.c +++ b/drivers/infiniband/ulp/ipoib/ipoib_multicast.c @@ -523,8 +523,11 @@ void ipoib_mcast_join_task(struct work_struct *work) if (!test_bit(IPOIB_MCAST_RUN, &priv->flags)) return; - if (ib_query_port(priv->ca, priv->port, &port_attr) || - port_attr.state != IB_PORT_ACTIVE) { + if (ib_query_port(priv->ca, priv->port, &port_attr)) { + ipoib_dbg(priv, "ib_query_port() failed\n"); + return; + } + if (port_attr.state != IB_PORT_ACTIVE) { ipoib_dbg(priv, "port state is not ACTIVE (state = %d) suspending join task\n", port_attr.state); return; |