summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTheodore Ts'o <tytso@mit.edu>2017-02-15 01:26:39 -0500
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2017-10-12 09:18:03 +0200
commitb7ff160a8ba4747edb774b1b2dde5417b7d4cf7a (patch)
treeeed64530015504754ab63ae10126b1908282d523
parent2ce649fdacd53afc430565e18124d7d72be92cb3 (diff)
downloadlinux-stable-b7ff160a8ba4747edb774b1b2dde5417b7d4cf7a.tar.gz
linux-stable-b7ff160a8ba4747edb774b1b2dde5417b7d4cf7a.tar.bz2
linux-stable-b7ff160a8ba4747edb774b1b2dde5417b7d4cf7a.zip
ext4: fix fencepost in s_first_meta_bg validation
commit 2ba3e6e8afc9b6188b471f27cf2b5e3cf34e7af2 upstream. It is OK for s_first_meta_bg to be equal to the number of block group descriptor blocks. (It rarely happens, but it shouldn't cause any problems.) https://bugzilla.kernel.org/show_bug.cgi?id=194567 Fixes: 3a4b77cd47bb837b8557595ec7425f281f2ca1fe Signed-off-by: Theodore Ts'o <tytso@mit.edu> Cc: Eryu Guan <guaneryu@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--fs/ext4/super.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index b7e0370171f9..51454eb4e4cb 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -3932,7 +3932,7 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
db_count = (sbi->s_groups_count + EXT4_DESC_PER_BLOCK(sb) - 1) /
EXT4_DESC_PER_BLOCK(sb);
if (EXT4_HAS_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_META_BG)) {
- if (le32_to_cpu(es->s_first_meta_bg) >= db_count) {
+ if (le32_to_cpu(es->s_first_meta_bg) > db_count) {
ext4_msg(sb, KERN_WARNING,
"first meta block group too large: %u "
"(group descriptor block count %u)",