diff options
| author | Jarkko Nikula <jarkko.nikula@linux.intel.com> | 2014-09-16 16:23:15 +0300 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2014-09-24 09:47:20 +0200 |
| commit | 324b0398781e7afb846378dd2d8a4374faaf236b (patch) | |
| tree | 4e6d55c8229c743f41efbc8c1e92906e3c732bdb | |
| parent | 72f908c88cef42b4ad486c39967fa4d7fdffce18 (diff) | |
| download | linux-stable-324b0398781e7afb846378dd2d8a4374faaf236b.tar.gz linux-stable-324b0398781e7afb846378dd2d8a4374faaf236b.tar.bz2 linux-stable-324b0398781e7afb846378dd2d8a4374faaf236b.zip | |
gpio: Fix potential NULL handler data in chained irqchip handler
There is possibility with misconfigured pins that interrupt occurs instantly
after setting irq_set_chained_handler() in gpiochip_set_chained_irqchip().
Now if handler gets called before irq_set_handler_data() the handler gets
NULL handler data.
Fix this by moving irq_set_handler_data() call before
irq_set_chained_handler() in gpiochip_set_chained_irqchip().
Cc: Stable <stable@vger.kernel.org> # 3.15+
Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
| -rw-r--r-- | drivers/gpio/gpiolib.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 3b54edf2befe..c68d037de656 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -413,12 +413,12 @@ void gpiochip_set_chained_irqchip(struct gpio_chip *gpiochip, return; } - irq_set_chained_handler(parent_irq, parent_handler); /* * The parent irqchip is already using the chip_data for this * irqchip, so our callbacks simply use the handler_data. */ irq_set_handler_data(parent_irq, gpiochip); + irq_set_chained_handler(parent_irq, parent_handler); } EXPORT_SYMBOL_GPL(gpiochip_set_chained_irqchip); |