diff options
| author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2019-04-16 10:17:22 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-05-16 19:42:33 +0200 |
| commit | 6b0a2ff3b329c68611faccbbb55fee07dc3a7664 (patch) | |
| tree | 67ce6e960dc5fead29c697188f9518ef9d0fa9b5 | |
| parent | 441941d201805b85aa21836bc905f955b41d2247 (diff) | |
| download | linux-stable-6b0a2ff3b329c68611faccbbb55fee07dc3a7664.tar.gz linux-stable-6b0a2ff3b329c68611faccbbb55fee07dc3a7664.tar.bz2 linux-stable-6b0a2ff3b329c68611faccbbb55fee07dc3a7664.zip | |
rtlwifi: rtl8723ae: Fix missing break in switch statement
commit 84242b82d81c54e009a2aaa74d3d9eff70babf56 upstream.
Add missing break statement in order to prevent the code from falling
through to case 0x1025, and erroneously setting rtlhal->oem_id to
RT_CID_819X_ACER when rtlefuse->eeprom_svid is equal to 0x10EC and
none of the cases in switch (rtlefuse->eeprom_smid) match.
This bug was found thanks to the ongoing efforts to enable
-Wimplicit-fallthrough.
Fixes: 238ad2ddf34b ("rtlwifi: rtl8723ae: Clean up the hardware info routine")
Cc: stable@vger.kernel.org
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c index 5ac7b815648a..7604a0bdaf2d 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c @@ -1699,6 +1699,7 @@ static void _rtl8723e_read_adapter_info(struct ieee80211_hw *hw, rtlhal->oem_id = RT_CID_819X_LENOVO; break; } + break; case 0x1025: rtlhal->oem_id = RT_CID_819X_ACER; break; |