summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorErqi Chen <chenerqi@gmail.com>2019-08-28 21:22:45 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-10-11 18:18:39 +0200
commit160f160e89386836427ce49bfe12c82bcdfa4fdf (patch)
tree83ce1566adb21a39a4a77b1655505c5e61c855b3
parentdff953adf050bf9856de8e9f741a0055256a0794 (diff)
downloadlinux-stable-160f160e89386836427ce49bfe12c82bcdfa4fdf.tar.gz
linux-stable-160f160e89386836427ce49bfe12c82bcdfa4fdf.tar.bz2
linux-stable-160f160e89386836427ce49bfe12c82bcdfa4fdf.zip
ceph: reconnect connection if session hang in opening state
[ Upstream commit 71a228bc8d65900179e37ac309e678f8c523f133 ] If client mds session is evicted in CEPH_MDS_SESSION_OPENING state, mds won't send session msg to client, and delayed_work skip CEPH_MDS_SESSION_OPENING state session, the session hang forever. Allow ceph_con_keepalive to reconnect a session in OPENING to avoid session hang. Also, ensure that we skip sessions in RESTARTING and REJECTED states since those states can't be resurrected by issuing a keepalive. Link: https://tracker.ceph.com/issues/41551 Signed-off-by: Erqi Chen chenerqi@gmail.com Reviewed-by: "Yan, Zheng" <zyan@redhat.com> Signed-off-by: Jeff Layton <jlayton@kernel.org> Signed-off-by: Ilya Dryomov <idryomov@gmail.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
-rw-r--r--fs/ceph/mds_client.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c
index e1ded4bd6115..b968334f841e 100644
--- a/fs/ceph/mds_client.c
+++ b/fs/ceph/mds_client.c
@@ -3543,7 +3543,9 @@ static void delayed_work(struct work_struct *work)
pr_info("mds%d hung\n", s->s_mds);
}
}
- if (s->s_state < CEPH_MDS_SESSION_OPEN) {
+ if (s->s_state == CEPH_MDS_SESSION_NEW ||
+ s->s_state == CEPH_MDS_SESSION_RESTARTING ||
+ s->s_state == CEPH_MDS_SESSION_REJECTED) {
/* this mds is failed or recovering, just wait */
ceph_put_mds_session(s);
continue;