summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMiquel Raynal <miquel.raynal@bootlin.com>2020-05-19 15:00:11 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2020-07-22 09:22:25 +0200
commite0c31e97437de14c5f5a8174771454f95dd5a87b (patch)
tree3892f915070755a79d2cf5094dfc2592c980e6c2
parent8e206ea49c2bbae1a828cbe2a6cd77920dfa3d03 (diff)
downloadlinux-stable-e0c31e97437de14c5f5a8174771454f95dd5a87b.tar.gz
linux-stable-e0c31e97437de14c5f5a8174771454f95dd5a87b.tar.bz2
linux-stable-e0c31e97437de14c5f5a8174771454f95dd5a87b.zip
mtd: rawnand: oxnas: Release all devices in the _remove() path
commit 0a5f45e57e35d0840bedb816974ce2e63406cd8b upstream. oxnans_nand_remove() should release all MTD devices and clean all NAND devices, not only the first one registered. Fixes: 668592492409 ("mtd: nand: Add OX820 NAND Support") Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-39-miquel.raynal@bootlin.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/mtd/nand/oxnas_nand.c8
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/mtd/nand/oxnas_nand.c b/drivers/mtd/nand/oxnas_nand.c
index 8a61a48af565..08b6ae364f2b 100644
--- a/drivers/mtd/nand/oxnas_nand.c
+++ b/drivers/mtd/nand/oxnas_nand.c
@@ -184,9 +184,13 @@ err_clk_unprepare:
static int oxnas_nand_remove(struct platform_device *pdev)
{
struct oxnas_nand_ctrl *oxnas = platform_get_drvdata(pdev);
+ struct nand_chip *chip;
+ int i;
- if (oxnas->chips[0])
- nand_release(oxnas->chips[0]);
+ for (i = 0; i < oxnas->nchips; i++) {
+ chip = oxnas->chips[i];
+ nand_release(chip);
+ }
clk_disable_unprepare(oxnas->clk);