diff options
| author | Wu Fengguang <fengguang.wu@intel.com> | 2014-12-24 14:41:39 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-12-24 15:18:09 -0500 |
| commit | 4aa6118811c09c75f508f3f070328c71292f1ce4 (patch) | |
| tree | b8045551586c133cc0fa859d53322b6827a3bc1b | |
| parent | b8fb4e0648a2ab3734140342002f68fb0c7d1602 (diff) | |
| download | linux-stable-4aa6118811c09c75f508f3f070328c71292f1ce4.tar.gz linux-stable-4aa6118811c09c75f508f3f070328c71292f1ce4.tar.bz2 linux-stable-4aa6118811c09c75f508f3f070328c71292f1ce4.zip | |
openvswitch: fix odd_ptr_err.cocci warnings
net/openvswitch/vport-gre.c:188:5-11: inconsistent IS_ERR and PTR_ERR, PTR_ERR on line 189
PTR_ERR should access the value just tested by IS_ERR
Semantic patch information:
There can be false positives in the patch case, where it is the call
IS_ERR that is wrong.
Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
CC: Pravin B Shelar <pshelar@nicira.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Acked-by: Pravin B Shelar <pshelar@nicira.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/openvswitch/vport-gre.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/openvswitch/vport-gre.c b/net/openvswitch/vport-gre.c index 28f54e9a6b80..d4168c442db5 100644 --- a/net/openvswitch/vport-gre.c +++ b/net/openvswitch/vport-gre.c @@ -186,7 +186,7 @@ static int gre_tnl_send(struct vport *vport, struct sk_buff *skb) /* Push Tunnel header. */ skb = __build_header(skb, tunnel_hlen); if (IS_ERR(skb)) { - err = PTR_ERR(rt); + err = PTR_ERR(skb); skb = NULL; goto err_free_rt; } |