diff options
| author | Wei Yongjun <weiyongjun1@huawei.com> | 2019-09-04 14:18:09 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-10-11 18:18:33 +0200 |
| commit | 72463f8295afca1933b027049dec96166f246791 (patch) | |
| tree | a52b3a753e280bf307a53cf84685445136c88578 | |
| parent | 61a2c2c94422b4d1a07405d1df9408fa3af2b4c6 (diff) | |
| download | linux-stable-72463f8295afca1933b027049dec96166f246791.tar.gz linux-stable-72463f8295afca1933b027049dec96166f246791.tar.bz2 linux-stable-72463f8295afca1933b027049dec96166f246791.zip | |
crypto: cavium/zip - Add missing single_release()
commit c552ffb5c93d9d65aaf34f5f001c4e7e8484ced1 upstream.
When using single_open() for opening, single_release() should be
used instead of seq_release(), otherwise there is a memory leak.
Fixes: 09ae5d37e093 ("crypto: zip - Add Compression/Decompression statistics")
Cc: <stable@vger.kernel.org>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/crypto/cavium/zip/zip_main.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/crypto/cavium/zip/zip_main.c b/drivers/crypto/cavium/zip/zip_main.c index a6425a7afa7b..279ffdd8b53d 100644 --- a/drivers/crypto/cavium/zip/zip_main.c +++ b/drivers/crypto/cavium/zip/zip_main.c @@ -595,6 +595,7 @@ static const struct file_operations zip_stats_fops = { .owner = THIS_MODULE, .open = zip_stats_open, .read = seq_read, + .release = single_release, }; static int zip_clear_open(struct inode *inode, struct file *file) @@ -606,6 +607,7 @@ static const struct file_operations zip_clear_fops = { .owner = THIS_MODULE, .open = zip_clear_open, .read = seq_read, + .release = single_release, }; static int zip_regs_open(struct inode *inode, struct file *file) @@ -617,6 +619,7 @@ static const struct file_operations zip_regs_fops = { .owner = THIS_MODULE, .open = zip_regs_open, .read = seq_read, + .release = single_release, }; /* Root directory for thunderx_zip debugfs entry */ |