diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2021-02-16 22:42:13 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-03-24 11:05:03 +0100 |
| commit | 9a429caa80b044915df720b36ee92c4416911513 (patch) | |
| tree | 194c1f366167e30b4a345351a8e4dcc4b0f0393b | |
| parent | cfdaec38d6045def9a4bc3a0cf96d0f089871361 (diff) | |
| download | linux-stable-9a429caa80b044915df720b36ee92c4416911513.tar.gz linux-stable-9a429caa80b044915df720b36ee92c4416911513.tar.bz2 linux-stable-9a429caa80b044915df720b36ee92c4416911513.zip | |
iio: adis16400: Fix an error code in adis16400_initial_setup()
commit a71266e454b5df10d019b06f5ebacd579f76be28 upstream.
This is to silence a new Smatch warning:
drivers/iio/imu/adis16400.c:492 adis16400_initial_setup()
warn: sscanf doesn't return error codes
If the condition "if (st->variant->flags & ADIS16400_HAS_SLOW_MODE) {"
is false then we return 1 instead of returning 0 and probe will fail.
Fixes: 72a868b38bdd ("iio: imu: check sscanf return value")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: <Stable@vger.kernel.org>
Link: https://lore.kernel.org/r/YCwgFb3JVG6qrlQ+@mwanda
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/iio/imu/adis16400_core.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/iio/imu/adis16400_core.c b/drivers/iio/imu/adis16400_core.c index 9b697d35dbef..af0904c42bd1 100644 --- a/drivers/iio/imu/adis16400_core.c +++ b/drivers/iio/imu/adis16400_core.c @@ -288,8 +288,7 @@ static int adis16400_initial_setup(struct iio_dev *indio_dev) if (ret) goto err_ret; - ret = sscanf(indio_dev->name, "adis%u\n", &device_id); - if (ret != 1) { + if (sscanf(indio_dev->name, "adis%u\n", &device_id) != 1) { ret = -EINVAL; goto err_ret; } |