diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2021-07-29 17:12:46 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-08-04 12:22:17 +0200 |
| commit | af3493a59fd8e493fa97ef42bb52b5017603de65 (patch) | |
| tree | aa84b5d3e36662cf47866557e5200256214938c0 | |
| parent | 6846170b0be30257c75901aeb7664cc1fc4477d2 (diff) | |
| download | linux-stable-af3493a59fd8e493fa97ef42bb52b5017603de65.tar.gz linux-stable-af3493a59fd8e493fa97ef42bb52b5017603de65.tar.bz2 linux-stable-af3493a59fd8e493fa97ef42bb52b5017603de65.zip | |
can: hi311x: fix a signedness bug in hi3110_cmd()
[ Upstream commit f6b3c7848e66e9046c8a79a5b88fd03461cc252b ]
The hi3110_cmd() is supposed to return zero on success and negative
error codes on failure, but it was accidentally declared as a u8 when
it needs to be an int type.
Fixes: 57e83fb9b746 ("can: hi311x: Add Holt HI-311x CAN driver")
Link: https://lore.kernel.org/r/20210729141246.GA1267@kili
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/net/can/spi/hi311x.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/can/spi/hi311x.c b/drivers/net/can/spi/hi311x.c index ddaf46239e39..472175e37055 100644 --- a/drivers/net/can/spi/hi311x.c +++ b/drivers/net/can/spi/hi311x.c @@ -236,7 +236,7 @@ static int hi3110_spi_trans(struct spi_device *spi, int len) return ret; } -static u8 hi3110_cmd(struct spi_device *spi, u8 command) +static int hi3110_cmd(struct spi_device *spi, u8 command) { struct hi3110_priv *priv = spi_get_drvdata(spi); |