summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2017-09-15 00:05:16 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2018-06-05 11:41:57 +0200
commit074e30a3fc09e7289143fd1ad2ae6edd126ee3ee (patch)
treeaaf13e3361e4c5ab568fe1334cca08f54a938ee9
parent5a92c6e3e2f3616cb801e33950dc8ec7d25dee0b (diff)
downloadlinux-stable-074e30a3fc09e7289143fd1ad2ae6edd126ee3ee.tar.gz
linux-stable-074e30a3fc09e7289143fd1ad2ae6edd126ee3ee.tar.bz2
linux-stable-074e30a3fc09e7289143fd1ad2ae6edd126ee3ee.zip
dma-buf: remove redundant initialization of sg_table
commit 531beb067c6185aceabfdee0965234c6a8fd133b upstream. sg_table is being initialized and is never read before it is updated again later on, hence making the initialization redundant. Remove the initialization. Detected by clang scan-build: "warning: Value stored to 'sg_table' during its initialization is never read" Signed-off-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> Link: https://patchwork.freedesktop.org/patch/msgid/20170914230516.6056-1-colin.king@canonical.com Cc: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/dma-buf/dma-buf.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c
index 4a038dcf5361..bc1cb284111c 100644
--- a/drivers/dma-buf/dma-buf.c
+++ b/drivers/dma-buf/dma-buf.c
@@ -625,7 +625,7 @@ EXPORT_SYMBOL_GPL(dma_buf_detach);
struct sg_table *dma_buf_map_attachment(struct dma_buf_attachment *attach,
enum dma_data_direction direction)
{
- struct sg_table *sg_table = ERR_PTR(-EINVAL);
+ struct sg_table *sg_table;
might_sleep();