summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPeter Hutterer <peter.hutterer@who-t.net>2017-12-04 10:26:17 +1000
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2017-12-25 14:26:31 +0100
commit0237a0a456563d461814111db15ae26666ce730e (patch)
tree8692dfb92b0ef362b72dff228845e40b2dcdd829
parent5431aef93678a1f91e8b3ab41076f2cd1be34353 (diff)
downloadlinux-stable-0237a0a456563d461814111db15ae26666ce730e.tar.gz
linux-stable-0237a0a456563d461814111db15ae26666ce730e.tar.bz2
linux-stable-0237a0a456563d461814111db15ae26666ce730e.zip
platform/x86: asus-wireless: send an EV_SYN/SYN_REPORT between state changes
commit bff5bf9db1c9453ffd0a78abed3e2d040c092fd9 upstream. Sending the switch state change twice within the same frame is invalid evdev protocol and only works if the client handles keys immediately as well. Processing events immediately is incorrect, it forces a fake order of events that does not exist on the device. Recent versions of libinput changed to only process the device state and SYN_REPORT time, so now the key event is lost. https://bugs.freedesktop.org/show_bug.cgi?id=104041 Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/platform/x86/asus-wireless.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/platform/x86/asus-wireless.c b/drivers/platform/x86/asus-wireless.c
index f3796164329e..d4aeac3477f5 100644
--- a/drivers/platform/x86/asus-wireless.c
+++ b/drivers/platform/x86/asus-wireless.c
@@ -118,6 +118,7 @@ static void asus_wireless_notify(struct acpi_device *adev, u32 event)
return;
}
input_report_key(data->idev, KEY_RFKILL, 1);
+ input_sync(data->idev);
input_report_key(data->idev, KEY_RFKILL, 0);
input_sync(data->idev);
}