diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2017-12-05 17:37:52 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-03-19 09:09:56 +0100 |
| commit | 736e6ed8e417070f449b7a20026d9973b51bc822 (patch) | |
| tree | 944df4c92a7cd1f218fc83c5bc689aff1b52c5d6 | |
| parent | 196c8a893cc317301035a4bf2494694e0350904a (diff) | |
| download | linux-stable-736e6ed8e417070f449b7a20026d9973b51bc822.tar.gz linux-stable-736e6ed8e417070f449b7a20026d9973b51bc822.tar.bz2 linux-stable-736e6ed8e417070f449b7a20026d9973b51bc822.zip | |
bnxt_en: Uninitialized variable in bnxt_tc_parse_actions()
[ Upstream commit 92425c40676d498efccae6fecdb8f8e4dcf7e4a4 ]
Smatch warns that:
drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:160 bnxt_tc_parse_actions()
error: uninitialized symbol 'rc'.
"rc" is either uninitialized or set to zero here so we can just remove
the check.
Fixes: 8c95f773b4a3 ("bnxt_en: add support for Flower based vxlan encap/decap offload")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c index d8fee26cd45e..aa484d72f38c 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c @@ -148,9 +148,6 @@ static int bnxt_tc_parse_actions(struct bnxt *bp, } } - if (rc) - return rc; - if (actions->flags & BNXT_TC_ACTION_FLAG_FWD) { if (actions->flags & BNXT_TC_ACTION_FLAG_TUNNEL_ENCAP) { /* dst_fid is PF's fid */ @@ -164,7 +161,7 @@ static int bnxt_tc_parse_actions(struct bnxt *bp, } } - return rc; + return 0; } #define GET_KEY(flow_cmd, key_type) \ |