diff options
| author | Charles Keepax <ckeepax@opensource.cirrus.com> | 2020-02-28 15:41:42 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-03-18 07:14:23 +0100 |
| commit | c62016bdc2da958b22b61979f742edf094d5955a (patch) | |
| tree | ddafef81d01ac94dfee5ea96bd1ea2950a42f155 | |
| parent | e0e86d976a14940440b88737916887576c9cee10 (diff) | |
| download | linux-stable-c62016bdc2da958b22b61979f742edf094d5955a.tar.gz linux-stable-c62016bdc2da958b22b61979f742edf094d5955a.tar.bz2 linux-stable-c62016bdc2da958b22b61979f742edf094d5955a.zip | |
pinctrl: core: Remove extra kref_get which blocks hogs being freed
commit aafd56fc79041bf36f97712d4b35208cbe07db90 upstream.
kref_init starts with the reference count at 1, which will be balanced
by the pinctrl_put in pinctrl_unregister. The additional kref_get in
pinctrl_claim_hogs will increase this count to 2 and cause the hogs to
not get freed when pinctrl_unregister is called.
Fixes: 6118714275f0 ("pinctrl: core: Fix pinctrl_register_and_init() with pinctrl_enable()")
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20200228154142.13860-1-ckeepax@opensource.cirrus.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/pinctrl/core.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c index c6ff4d5fa482..76638dee65d9 100644 --- a/drivers/pinctrl/core.c +++ b/drivers/pinctrl/core.c @@ -2008,7 +2008,6 @@ static int pinctrl_claim_hogs(struct pinctrl_dev *pctldev) return PTR_ERR(pctldev->p); } - kref_get(&pctldev->p->users); pctldev->hog_default = pinctrl_lookup_state(pctldev->p, PINCTRL_STATE_DEFAULT); if (IS_ERR(pctldev->hog_default)) { |