summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAl Viro <viro@zeniv.linux.org.uk>2020-09-24 19:41:58 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2020-10-07 08:00:09 +0200
commitced8ce5d2157142c469eccc5eef5ea8ad579fa5e (patch)
tree18f4bff926582cceaf81baefc5fc614a815f2a49
parent90ef231ba534d43033884b8560df26e608ca0a21 (diff)
downloadlinux-stable-ced8ce5d2157142c469eccc5eef5ea8ad579fa5e.tar.gz
linux-stable-ced8ce5d2157142c469eccc5eef5ea8ad579fa5e.tar.bz2
linux-stable-ced8ce5d2157142c469eccc5eef5ea8ad579fa5e.zip
ep_create_wakeup_source(): dentry name can change under you...
commit 3701cb59d892b88d569427586f01491552f377b1 upstream. or get freed, for that matter, if it's a long (separately stored) name. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--fs/eventpoll.c7
1 files changed, 4 insertions, 3 deletions
diff --git a/fs/eventpoll.c b/fs/eventpoll.c
index c4c833bad4b7..a4a32b79e832 100644
--- a/fs/eventpoll.c
+++ b/fs/eventpoll.c
@@ -1376,7 +1376,7 @@ static int reverse_path_check(void)
static int ep_create_wakeup_source(struct epitem *epi)
{
- const char *name;
+ struct name_snapshot n;
struct wakeup_source *ws;
if (!epi->ep->ws) {
@@ -1385,8 +1385,9 @@ static int ep_create_wakeup_source(struct epitem *epi)
return -ENOMEM;
}
- name = epi->ffd.file->f_path.dentry->d_name.name;
- ws = wakeup_source_register(name);
+ take_dentry_name_snapshot(&n, epi->ffd.file->f_path.dentry);
+ ws = wakeup_source_register(n.name);
+ release_dentry_name_snapshot(&n);
if (!ws)
return -ENOMEM;