summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMatthew Wilcox (Oracle) <willy@infradead.org>2021-03-12 21:08:03 -0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2021-03-17 16:43:51 +0100
commit5bd7642bd62805a91f5e90d4af8b5465515273f5 (patch)
tree06a197657c51679dd2a4616eb26ebcead51bca03
parent25d754fa5df92c732ff24e78e5452580cb4db767 (diff)
downloadlinux-stable-5bd7642bd62805a91f5e90d4af8b5465515273f5.tar.gz
linux-stable-5bd7642bd62805a91f5e90d4af8b5465515273f5.tar.bz2
linux-stable-5bd7642bd62805a91f5e90d4af8b5465515273f5.zip
include/linux/sched/mm.h: use rcu_dereference in in_vfork()
[ Upstream commit 149fc787353f65b7e72e05e7b75d34863266c3e2 ] Fix a sparse warning by using rcu_dereference(). Technically this is a bug and a sufficiently aggressive compiler could reload the `real_parent' pointer outside the protection of the rcu lock (and access freed memory), but I think it's pretty unlikely to happen. Link: https://lkml.kernel.org/r/20210221194207.1351703-1-willy@infradead.org Fixes: b18dc5f291c0 ("mm, oom: skip vforked tasks from being selected") Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> Reviewed-by: Miaohe Lin <linmiaohe@huawei.com> Acked-by: Michal Hocko <mhocko@suse.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
-rw-r--r--include/linux/sched/mm.h3
1 files changed, 2 insertions, 1 deletions
diff --git a/include/linux/sched/mm.h b/include/linux/sched/mm.h
index 8d3b7e731b74..ef54f4b3f1e4 100644
--- a/include/linux/sched/mm.h
+++ b/include/linux/sched/mm.h
@@ -167,7 +167,8 @@ static inline bool in_vfork(struct task_struct *tsk)
* another oom-unkillable task does this it should blame itself.
*/
rcu_read_lock();
- ret = tsk->vfork_done && tsk->real_parent->mm == tsk->mm;
+ ret = tsk->vfork_done &&
+ rcu_dereference(tsk->real_parent)->mm == tsk->mm;
rcu_read_unlock();
return ret;