summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorXiaoke Wang <xkernel.wang@foxmail.com>2021-12-17 01:01:33 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2022-02-16 12:51:44 +0100
commit2c9587f72ff4b502c2fd15eb3ccff388eae12d07 (patch)
tree5ea39879755360cf2249c591f4297e7765d34f5f
parent1789f59f1779c99d0756b40036c62a7519f53543 (diff)
downloadlinux-stable-2c9587f72ff4b502c2fd15eb3ccff388eae12d07.tar.gz
linux-stable-2c9587f72ff4b502c2fd15eb3ccff388eae12d07.tar.bz2
linux-stable-2c9587f72ff4b502c2fd15eb3ccff388eae12d07.zip
nfs: nfs4clinet: check the return value of kstrdup()
[ Upstream commit fbd2057e5329d3502a27491190237b6be52a1cb6 ] kstrdup() returns NULL when some internal memory errors happen, it is better to check the return value of it so to catch the memory error in time. Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com> Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
-rw-r--r--fs/nfs/nfs4client.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/fs/nfs/nfs4client.c b/fs/nfs/nfs4client.c
index 43659326b519..c97ec2fa0bbc 100644
--- a/fs/nfs/nfs4client.c
+++ b/fs/nfs/nfs4client.c
@@ -1273,8 +1273,11 @@ int nfs4_update_server(struct nfs_server *server, const char *hostname,
}
nfs_put_client(clp);
- if (server->nfs_client->cl_hostname == NULL)
+ if (server->nfs_client->cl_hostname == NULL) {
server->nfs_client->cl_hostname = kstrdup(hostname, GFP_KERNEL);
+ if (server->nfs_client->cl_hostname == NULL)
+ return -ENOMEM;
+ }
nfs_server_insert_lists(server);
return nfs_probe_destination(server);