summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMuhammad Usama Anjum <usama.anjum@collabora.com>2022-02-14 23:41:08 +0500
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2022-04-15 14:14:43 +0200
commitc40625dcdda55043b32fc2b53baa0dc645c9167c (patch)
treeb9045c62160b3bad646ff155d53a245423b3acd5
parent841a2a43f0c620eb57c967b4420d38bd9dcd4813 (diff)
downloadlinux-stable-c40625dcdda55043b32fc2b53baa0dc645c9167c.tar.gz
linux-stable-c40625dcdda55043b32fc2b53baa0dc645c9167c.tar.bz2
linux-stable-c40625dcdda55043b32fc2b53baa0dc645c9167c.zip
selftests/x86: Add validity check and allow field splitting
[ Upstream commit b06e15ebd5bfb670f93c7f11a29b8299c1178bc6 ] Add check to test if CC has a string. CC can have multiple sub-strings like "ccache gcc". Erorr pops up if it is treated as single string and double quotes are used around it. This can be fixed by removing the quotes and not treating CC as a single string. Fixes: e9886ace222e ("selftests, x86: Rework x86 target architecture detection") Reported-by: "kernelci.org bot" <bot@kernelci.org> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com> Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com> Link: https://lkml.kernel.org/r/20220214184109.3739179-2-usama.anjum@collabora.com Signed-off-by: Sasha Levin <sashal@kernel.org>
-rwxr-xr-xtools/testing/selftests/x86/check_cc.sh2
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/testing/selftests/x86/check_cc.sh b/tools/testing/selftests/x86/check_cc.sh
index 172d3293fb7b..356689c56397 100755
--- a/tools/testing/selftests/x86/check_cc.sh
+++ b/tools/testing/selftests/x86/check_cc.sh
@@ -7,7 +7,7 @@ CC="$1"
TESTPROG="$2"
shift 2
-if "$CC" -o /dev/null "$TESTPROG" -O0 "$@" 2>/dev/null; then
+if [ -n "$CC" ] && $CC -o /dev/null "$TESTPROG" -O0 "$@" 2>/dev/null; then
echo 1
else
echo 0