summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSudip Mukherjee <sudipm.mukherjee@gmail.com>2019-12-27 17:44:34 +0000
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2020-01-14 20:07:06 +0100
commit1656f00becca4b6aa3e6992e6a6304dd74ec473b (patch)
treed61d01dde665c65f9299fed1edf925719f44f02a
parent65c6710c3fab92dcdf924c1a6daf75439f7f3199 (diff)
downloadlinux-stable-1656f00becca4b6aa3e6992e6a6304dd74ec473b.tar.gz
linux-stable-1656f00becca4b6aa3e6992e6a6304dd74ec473b.tar.bz2
linux-stable-1656f00becca4b6aa3e6992e6a6304dd74ec473b.zip
tty: always relink the port
commit 273f632912f1b24b642ba5b7eb5022e43a72f3b5 upstream. If the serial device is disconnected and reconnected, it re-enumerates properly but does not link it. fwiw, linking means just saving the port index, so allow it always as there is no harm in saving the same value again even if it tries to relink with the same port. Fixes: fb2b90014d78 ("tty: link tty and port before configuring it as console") Reported-by: Kenneth R. Crudup <kenny@panix.com> Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com> Cc: stable <stable@vger.kernel.org> Link: https://lore.kernel.org/r/20191227174434.12057-1-sudipm.mukherjee@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/tty/tty_port.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/tty/tty_port.c b/drivers/tty/tty_port.c
index 4ddd9d66a0b6..c699d41a2a48 100644
--- a/drivers/tty/tty_port.c
+++ b/drivers/tty/tty_port.c
@@ -89,8 +89,7 @@ void tty_port_link_device(struct tty_port *port,
{
if (WARN_ON(index >= driver->num))
return;
- if (!driver->ports[index])
- driver->ports[index] = port;
+ driver->ports[index] = port;
}
EXPORT_SYMBOL_GPL(tty_port_link_device);