diff options
| author | Daniel Thompson <daniel.thompson@linaro.org> | 2024-02-20 15:35:25 +0000 |
|---|---|---|
| committer | Sasha Levin <sashal@kernel.org> | 2024-03-26 18:22:41 -0400 |
| commit | 9d0aaf425cc5aec627ee7cae0990e6c5b7d2adb9 (patch) | |
| tree | 2796024cb693fdb9ee41ed267c7f068a06cf8532 | |
| parent | ba9f50fa0edd4d45bc9840ba05efa9b526a30b53 (diff) | |
| download | linux-stable-9d0aaf425cc5aec627ee7cae0990e6c5b7d2adb9.tar.gz linux-stable-9d0aaf425cc5aec627ee7cae0990e6c5b7d2adb9.tar.bz2 linux-stable-9d0aaf425cc5aec627ee7cae0990e6c5b7d2adb9.zip | |
backlight: lm3639: Fully initialize backlight_properties during probe
[ Upstream commit abb5a5d951fbea3feb5c4ba179b89bb96a1d3462 ]
props is stack allocated and the fields that are not explcitly set
by the probe function need to be zeroed or we'll get undefined behaviour
(especially so power/blank states)!
Fixes: 0f59858d5119 ("backlight: add new lm3639 backlight driver")
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
Link: https://lore.kernel.org/r/20240220153532.76613-3-daniel.thompson@linaro.org
Signed-off-by: Lee Jones <lee@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/video/backlight/lm3639_bl.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/video/backlight/lm3639_bl.c b/drivers/video/backlight/lm3639_bl.c index 086611c7bc03..a1ef6f23156d 100644 --- a/drivers/video/backlight/lm3639_bl.c +++ b/drivers/video/backlight/lm3639_bl.c @@ -343,6 +343,7 @@ static int lm3639_probe(struct i2c_client *client, } /* backlight */ + memset(&props, 0, sizeof(struct backlight_properties)); props.type = BACKLIGHT_RAW; props.brightness = pdata->init_brt_led; props.max_brightness = pdata->max_brt_led; |