diff options
| author | Harry Wentland <harry.wentland@amd.com> | 2023-11-08 11:36:20 -0500 |
|---|---|---|
| committer | Sasha Levin <sashal@kernel.org> | 2024-03-26 18:22:37 -0400 |
| commit | e3271a9f1432472bfd1aec82a5086d6b10e0dfec (patch) | |
| tree | e5dd750caadbee5209ea7de7f3329a10ef0fd0d3 | |
| parent | c031022829a91114cb2bd531c38de99184957b6d (diff) | |
| download | linux-stable-e3271a9f1432472bfd1aec82a5086d6b10e0dfec.tar.gz linux-stable-e3271a9f1432472bfd1aec82a5086d6b10e0dfec.tar.bz2 linux-stable-e3271a9f1432472bfd1aec82a5086d6b10e0dfec.zip | |
drm: Don't treat 0 as -1 in drm_fixp2int_ceil
[ Upstream commit cf8837d7204481026335461629b84ac7f4538fa5 ]
Unit testing this in VKMS shows that passing 0 into
this function returns -1, which is highly counter-
intuitive. Fix it by checking whether the input is
>= 0 instead of > 0.
Fixes: 64566b5e767f ("drm: Add drm_fixp_from_fraction and drm_fixp2int_ceil")
Signed-off-by: Harry Wentland <harry.wentland@amd.com>
Reviewed-by: Simon Ser <contact@emersion.fr>
Reviewed-by: Melissa Wen <mwen@igalia.com>
Signed-off-by: Melissa Wen <melissa.srw@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231108163647.106853-2-harry.wentland@amd.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | include/drm/drm_fixed.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/drm/drm_fixed.h b/include/drm/drm_fixed.h index 553210c02ee0..627efa56e59f 100644 --- a/include/drm/drm_fixed.h +++ b/include/drm/drm_fixed.h @@ -88,7 +88,7 @@ static inline int drm_fixp2int(s64 a) static inline int drm_fixp2int_ceil(s64 a) { - if (a > 0) + if (a >= 0) return drm_fixp2int(a + DRM_FIXED_ALMOST_ONE); else return drm_fixp2int(a - DRM_FIXED_ALMOST_ONE); |