summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTobias Jungel <tobias.jungel@gmail.com>2018-10-28 12:54:10 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2018-11-04 14:50:52 +0100
commit655b0860ca7e03297bfeb75209fb6393f2656a2f (patch)
tree501bf9903edb4c2018b4f718f5e3ed98d104d430
parent26ab2eb87000532dc31a14210e85f5f4efeeab17 (diff)
downloadlinux-stable-655b0860ca7e03297bfeb75209fb6393f2656a2f.tar.gz
linux-stable-655b0860ca7e03297bfeb75209fb6393f2656a2f.tar.bz2
linux-stable-655b0860ca7e03297bfeb75209fb6393f2656a2f.zip
bonding: fix length of actor system
[ Upstream commit 414dd6fb9a1a1b59983aea7bf0f79f0085ecc5b8 ] The attribute IFLA_BOND_AD_ACTOR_SYSTEM is sent to user space having the length of sizeof(bond->params.ad_actor_system) which is 8 byte. This patch aligns the length to ETH_ALEN to have the same MAC address exposed as using sysfs. Fixes: f87fda00b6ed2 ("bonding: prevent out of bound accesses") Signed-off-by: Tobias Jungel <tobias.jungel@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/net/bonding/bond_netlink.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/bonding/bond_netlink.c b/drivers/net/bonding/bond_netlink.c
index 9697977b80f0..6b9ad8673218 100644
--- a/drivers/net/bonding/bond_netlink.c
+++ b/drivers/net/bonding/bond_netlink.c
@@ -638,8 +638,7 @@ static int bond_fill_info(struct sk_buff *skb,
goto nla_put_failure;
if (nla_put(skb, IFLA_BOND_AD_ACTOR_SYSTEM,
- sizeof(bond->params.ad_actor_system),
- &bond->params.ad_actor_system))
+ ETH_ALEN, &bond->params.ad_actor_system))
goto nla_put_failure;
}
if (!bond_3ad_get_active_agg_info(bond, &info)) {