diff options
| author | Navid Emamdoost <navid.emamdoost@gmail.com> | 2019-10-04 15:24:39 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-10-07 18:57:22 +0200 |
| commit | 9d0995cc268b4a431dbfb29db5cac36546732bc0 (patch) | |
| tree | 75ea6bfc7d59212a46918565b099510007b08dc4 | |
| parent | 124b64feafa9c3825d8b6834d34dbdc6d7fd9b13 (diff) | |
| download | linux-stable-9d0995cc268b4a431dbfb29db5cac36546732bc0.tar.gz linux-stable-9d0995cc268b4a431dbfb29db5cac36546732bc0.tar.bz2 linux-stable-9d0995cc268b4a431dbfb29db5cac36546732bc0.zip | |
net: qlogic: Fix memory leak in ql_alloc_large_buffers
[ Upstream commit 1acb8f2a7a9f10543868ddd737e37424d5c36cf4 ]
In ql_alloc_large_buffers, a new skb is allocated via netdev_alloc_skb.
This skb should be released if pci_dma_mapping_error fails.
Fixes: 0f8ab89e825f ("qla3xxx: Check return code from pci_map_single() in ql_release_to_lrg_buf_free_list(), ql_populate_free_queue(), ql_alloc_large_buffers(), and ql3xxx_send()")
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/net/ethernet/qlogic/qla3xxx.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/ethernet/qlogic/qla3xxx.c b/drivers/net/ethernet/qlogic/qla3xxx.c index 10b075bc5959..783ee6a32b5d 100644 --- a/drivers/net/ethernet/qlogic/qla3xxx.c +++ b/drivers/net/ethernet/qlogic/qla3xxx.c @@ -2788,6 +2788,7 @@ static int ql_alloc_large_buffers(struct ql3_adapter *qdev) netdev_err(qdev->ndev, "PCI mapping failed with error: %d\n", err); + dev_kfree_skb_irq(skb); ql_free_large_buffers(qdev); return -ENOMEM; } |