diff options
| author | Sasha Levin <sasha.levin@oracle.com> | 2016-01-07 14:52:43 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-01-31 11:28:59 -0800 |
| commit | 8534537d0b7914346c1d80dd374976b6bcbe508e (patch) | |
| tree | a0c464c3f3250839bda86843c9a1ffa6069ef7f4 | |
| parent | 0f3302adebc81256c724af7507909ad9b81f2036 (diff) | |
| download | linux-stable-8534537d0b7914346c1d80dd374976b6bcbe508e.tar.gz linux-stable-8534537d0b7914346c1d80dd374976b6bcbe508e.tar.bz2 linux-stable-8534537d0b7914346c1d80dd374976b6bcbe508e.zip | |
net: sctp: prevent writes to cookie_hmac_alg from accessing invalid memory
[ Upstream commit 320f1a4a175e7cd5d3f006f92b4d4d3e2cbb7bb5 ]
proc_dostring() needs an initialized destination string, while the one
provided in proc_sctp_do_hmac_alg() contains stack garbage.
Thus, writing to cookie_hmac_alg would strlen() that garbage and end up
accessing invalid memory.
Fixes: 3c68198e7 ("sctp: Make hmac algorithm selection for cookie generation dynamic")
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | net/sctp/sysctl.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/sctp/sysctl.c b/net/sctp/sysctl.c index 26d50c565f54..3e0fc5127225 100644 --- a/net/sctp/sysctl.c +++ b/net/sctp/sysctl.c @@ -320,7 +320,7 @@ static int proc_sctp_do_hmac_alg(struct ctl_table *ctl, int write, struct ctl_table tbl; bool changed = false; char *none = "none"; - char tmp[8]; + char tmp[8] = {0}; int ret; memset(&tbl, 0, sizeof(struct ctl_table)); |