diff options
| author | Vignesh R <vigneshr@ti.com> | 2016-06-09 11:02:04 +0530 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-08-20 18:09:17 +0200 |
| commit | 4a2773383ff778fc050e45f975adbcdc79df003d (patch) | |
| tree | 855e7750995739454d20be38a1891cc079bec15a | |
| parent | 580b1bbcc94e37d24e7469b3778338e4e988b190 (diff) | |
| download | linux-stable-4a2773383ff778fc050e45f975adbcdc79df003d.tar.gz linux-stable-4a2773383ff778fc050e45f975adbcdc79df003d.tar.bz2 linux-stable-4a2773383ff778fc050e45f975adbcdc79df003d.zip | |
gpio: pca953x: Fix NBANK calculation for PCA9536
commit a246b8198f776a16d1d3a3bbfc2d437bad766b29 upstream.
NBANK() macro assumes that ngpios is a multiple of 8(BANK_SZ) and
hence results in 0 banks for PCA9536 which has just 4 gpios. This is
wrong as PCA9356 has 1 bank with 4 gpios. This results in uninitialized
PCA953X_INVERT register. Fix this by using DIV_ROUND_UP macro in
NBANK().
Signed-off-by: Vignesh R <vigneshr@ti.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/gpio/gpio-pca953x.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c index 2d4892cc70fb..c844d7eccb6c 100644 --- a/drivers/gpio/gpio-pca953x.c +++ b/drivers/gpio/gpio-pca953x.c @@ -86,7 +86,7 @@ MODULE_DEVICE_TABLE(acpi, pca953x_acpi_ids); #define MAX_BANK 5 #define BANK_SZ 8 -#define NBANK(chip) (chip->gpio_chip.ngpio / BANK_SZ) +#define NBANK(chip) DIV_ROUND_UP(chip->gpio_chip.ngpio, BANK_SZ) struct pca953x_chip { unsigned gpio_start; |