diff options
| author | Yingjoe Chen <yingjoe.chen@mediatek.com> | 2019-05-07 22:20:32 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-06-22 08:18:26 +0200 |
| commit | d5a18c8609f3ccabe102caf45b8887ca6e19e69a (patch) | |
| tree | 922d7178c3bcbabaeaef35cac729fd08864431db | |
| parent | be1b9df5bba102359f1dcaac97425e092723c1ac (diff) | |
| download | linux-stable-d5a18c8609f3ccabe102caf45b8887ca6e19e69a.tar.gz linux-stable-d5a18c8609f3ccabe102caf45b8887ca6e19e69a.tar.bz2 linux-stable-d5a18c8609f3ccabe102caf45b8887ca6e19e69a.zip | |
i2c: dev: fix potential memory leak in i2cdev_ioctl_rdwr
[ Upstream commit a0692f0eef91354b62c2b4c94954536536be5425 ]
If I2C_M_RECV_LEN check failed, msgs[i].buf allocated by memdup_user
will not be freed. Pump index up so it will be freed.
Fixes: 838bfa6049fb ("i2c-dev: Add support for I2C_M_RECV_LEN")
Signed-off-by: Yingjoe Chen <yingjoe.chen@mediatek.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/i2c/i2c-dev.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/i2c/i2c-dev.c b/drivers/i2c/i2c-dev.c index 57e3790c87b1..e56b774e7cf9 100644 --- a/drivers/i2c/i2c-dev.c +++ b/drivers/i2c/i2c-dev.c @@ -295,6 +295,7 @@ static noinline int i2cdev_ioctl_rdwr(struct i2c_client *client, rdwr_pa[i].buf[0] < 1 || rdwr_pa[i].len < rdwr_pa[i].buf[0] + I2C_SMBUS_BLOCK_MAX) { + i++; res = -EINVAL; break; } |