diff options
| author | Colin Ian King <colin.king@canonical.com> | 2020-08-06 15:35:34 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-08-21 10:53:07 +0200 |
| commit | 4cb6d2290c1a53cccfd6bd64fe93c7886a9aaf5b (patch) | |
| tree | e5b53639252d657f2bc17ea1ee37f58e327e199e | |
| parent | d8d87cae0d59e4a03c78621015fd28f8a54540bd (diff) | |
| download | linux-stable-4cb6d2290c1a53cccfd6bd64fe93c7886a9aaf5b.tar.gz linux-stable-4cb6d2290c1a53cccfd6bd64fe93c7886a9aaf5b.tar.bz2 linux-stable-4cb6d2290c1a53cccfd6bd64fe93c7886a9aaf5b.zip | |
Input: sentelic - fix error return when fsp_reg_write fails
[ Upstream commit ea38f06e0291986eb93beb6d61fd413607a30ca4 ]
Currently when the call to fsp_reg_write fails -EIO is not being returned
because the count is being returned instead of the return value in retval.
Fix this by returning the value in retval instead of count.
Addresses-Coverity: ("Unused value")
Fixes: fc69f4a6af49 ("Input: add new driver for Sentelic Finger Sensing Pad")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20200603141218.131663-1-colin.king@canonical.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/input/mouse/sentelic.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/input/mouse/sentelic.c b/drivers/input/mouse/sentelic.c index 11c32ac8234b..779d0b9341c0 100644 --- a/drivers/input/mouse/sentelic.c +++ b/drivers/input/mouse/sentelic.c @@ -454,7 +454,7 @@ static ssize_t fsp_attr_set_setreg(struct psmouse *psmouse, void *data, fsp_reg_write_enable(psmouse, false); - return count; + return retval; } PSMOUSE_DEFINE_WO_ATTR(setreg, S_IWUSR, NULL, fsp_attr_set_setreg); |