summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorWang Hai <wanghai38@huawei.com>2020-11-10 22:46:14 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2020-11-18 18:25:00 +0100
commit3c9d5cf886fae11c0ae3c033f873c18029fe324b (patch)
tree4e9ad957f186d88f1c469e1495aa53f2b1cee78e
parent2e4d9fac404b2674532c363ce203dc30372c7f7a (diff)
downloadlinux-stable-3c9d5cf886fae11c0ae3c033f873c18029fe324b.tar.gz
linux-stable-3c9d5cf886fae11c0ae3c033f873c18029fe324b.tar.bz2
linux-stable-3c9d5cf886fae11c0ae3c033f873c18029fe324b.zip
cosa: Add missing kfree in error path of cosa_write
[ Upstream commit 52755b66ddcef2e897778fac5656df18817b59ab ] If memory allocation for 'kbuf' succeed, cosa_write() doesn't have a corresponding kfree() in exception handling. Thus add kfree() for this function implementation. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Wang Hai <wanghai38@huawei.com> Acked-by: Jan "Yenya" Kasprzak <kas@fi.muni.cz> Link: https://lore.kernel.org/r/20201110144614.43194-1-wanghai38@huawei.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
-rw-r--r--drivers/net/wan/cosa.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/wan/cosa.c b/drivers/net/wan/cosa.c
index 848ea6a399f2..cbda69e58e08 100644
--- a/drivers/net/wan/cosa.c
+++ b/drivers/net/wan/cosa.c
@@ -903,6 +903,7 @@ static ssize_t cosa_write(struct file *file,
chan->tx_status = 1;
spin_unlock_irqrestore(&cosa->lock, flags);
up(&chan->wsem);
+ kfree(kbuf);
return -ERESTARTSYS;
}
}