diff options
| author | Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2021-08-21 12:37:24 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-10-27 09:32:38 +0200 |
| commit | 43f8cf1ef2b11e49e3ce75e346b723f61c654fad (patch) | |
| tree | 10dc7617e47575264c3c0fe5fc172067a06d893f | |
| parent | abcb8d33e4d2215ccde5ab5ccf9f730a59d79d97 (diff) | |
| download | linux-stable-43f8cf1ef2b11e49e3ce75e346b723f61c654fad.tar.gz linux-stable-43f8cf1ef2b11e49e3ce75e346b723f61c654fad.tar.bz2 linux-stable-43f8cf1ef2b11e49e3ce75e346b723f61c654fad.zip | |
iio: adc128s052: Fix the error handling path of 'adc128_probe()'
commit bbcf40816b547b3c37af49168950491d20d81ce1 upstream.
A successful 'regulator_enable()' call should be balanced by a
corresponding 'regulator_disable()' call in the error handling path of the
probe, as already done in the remove function.
Update the error handling path accordingly.
Fixes: 913b86468674 ("iio: adc: Add TI ADC128S052")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Link: https://lore.kernel.org/r/85189f1cfcf6f5f7b42d8730966f2a074b07b5f5.1629542160.git.christophe.jaillet@wanadoo.fr
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/iio/adc/ti-adc128s052.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/iio/adc/ti-adc128s052.c b/drivers/iio/adc/ti-adc128s052.c index ff6f7f63c8d9..27b8de41e34a 100644 --- a/drivers/iio/adc/ti-adc128s052.c +++ b/drivers/iio/adc/ti-adc128s052.c @@ -159,7 +159,13 @@ static int adc128_probe(struct spi_device *spi) mutex_init(&adc->lock); ret = iio_device_register(indio_dev); + if (ret) + goto err_disable_regulator; + return 0; + +err_disable_regulator: + regulator_disable(adc->reg); return ret; } |