diff options
| author | Josef Bacik <jbacik@fb.com> | 2016-09-02 15:25:43 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-01-06 11:16:10 +0100 |
| commit | 5a9b659edef60fb665786525528086b5df5e0e19 (patch) | |
| tree | 5e9a6d95caf18464721104fa5a54ee92b2a31223 | |
| parent | 8ca6845a58cda0cda9359eb313af35c2f88df073 (diff) | |
| download | linux-stable-5a9b659edef60fb665786525528086b5df5e0e19.tar.gz linux-stable-5a9b659edef60fb665786525528086b5df5e0e19.tar.bz2 linux-stable-5a9b659edef60fb665786525528086b5df5e0e19.zip | |
Btrfs: don't leak reloc root nodes on error
commit 6bdf131fac2336adb1a628f992ba32384f653a55 upstream.
We don't track the reloc roots in any sort of normal way, so the only way the
root/commit_root nodes get free'd is if the relocation finishes successfully and
the reloc root is deleted. Fix this by free'ing them in free_reloc_roots.
Thanks,
Signed-off-by: Josef Bacik <jbacik@fb.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | fs/btrfs/relocation.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c index 937d015422e0..8ca9aa92972d 100644 --- a/fs/btrfs/relocation.c +++ b/fs/btrfs/relocation.c @@ -2350,6 +2350,10 @@ void free_reloc_roots(struct list_head *list) while (!list_empty(list)) { reloc_root = list_entry(list->next, struct btrfs_root, root_list); + free_extent_buffer(reloc_root->node); + free_extent_buffer(reloc_root->commit_root); + reloc_root->node = NULL; + reloc_root->commit_root = NULL; __del_reloc_root(reloc_root); } } |