diff options
| author | Rui Wang <rui.y.wang@intel.com> | 2016-01-08 23:09:59 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-03-16 08:43:01 -0700 |
| commit | 2f639e2e95ea8c06f287f768bc17d03d43480d0d (patch) | |
| tree | 39a3234617e7f191745523a19ced1bcbba5969c5 | |
| parent | b3600dd6476cd5ce390991860789163aa109f490 (diff) | |
| download | linux-stable-2f639e2e95ea8c06f287f768bc17d03d43480d0d.tar.gz linux-stable-2f639e2e95ea8c06f287f768bc17d03d43480d0d.tar.bz2 linux-stable-2f639e2e95ea8c06f287f768bc17d03d43480d0d.zip | |
ovl: fix getcwd() failure after unsuccessful rmdir
commit ce9113bbcbf45a57c082d6603b9a9f342be3ef74 upstream.
ovl_remove_upper() should do d_drop() only after it successfully
removes the dir, otherwise a subsequent getcwd() system call will
fail, breaking userspace programs.
This is to fix: https://bugzilla.kernel.org/show_bug.cgi?id=110491
Signed-off-by: Rui Wang <rui.y.wang@intel.com>
Reviewed-by: Konstantin Khlebnikov <koct9i@gmail.com>
Signed-off-by: Miklos Szeredi <miklos@szeredi.hu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | fs/overlayfs/dir.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/overlayfs/dir.c b/fs/overlayfs/dir.c index 007e61eb2358..a2b1d7ce3e1a 100644 --- a/fs/overlayfs/dir.c +++ b/fs/overlayfs/dir.c @@ -618,7 +618,8 @@ static int ovl_remove_upper(struct dentry *dentry, bool is_dir) * sole user of this dentry. Too tricky... Just unhash for * now. */ - d_drop(dentry); + if (!err) + d_drop(dentry); mutex_unlock(&dir->i_mutex); return err; |