diff options
| author | Thomas Petazzoni <thomas.petazzoni@free-electrons.com> | 2016-06-16 16:48:52 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-08-16 09:35:00 +0200 |
| commit | 5b3045bc26bf4f7ee0817672daef69e65f63a252 (patch) | |
| tree | bc54e41a9ac39a6bde46cf84b52d51a118e5e141 | |
| parent | 1539c4d5d3df046cb36c3fed2ea435c34abc4e05 (diff) | |
| download | linux-stable-5b3045bc26bf4f7ee0817672daef69e65f63a252.tar.gz linux-stable-5b3045bc26bf4f7ee0817672daef69e65f63a252.tar.bz2 linux-stable-5b3045bc26bf4f7ee0817672daef69e65f63a252.zip | |
serial: mvebu-uart: free the IRQ in ->shutdown()
commit c2c1659b4f8f9e19fe82a4fd06cca4b3d59090ce upstream.
As suggested by the serial port infrastructure documentation, the IRQ is
requested in ->startup(). However, it is never freed in the ->shutdown()
hook.
With simple systems that open the serial port once for all and always
have at least one process that keep the serial port opened, there was no
problem. But with a more complicated system (*cough* systemd *cough*),
the serial port is opened/closed many times, which at some point no
processes having the serial port open at all. Due to this ->startup()
gets called again, tries to request_irq() again, which fails.
Fixes: 30530791a7a0 ("serial: mvebu-uart: initial support for Armada-3700 serial port")
Cc: Ofer Heifetz <oferh@marvell.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/tty/serial/mvebu-uart.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/tty/serial/mvebu-uart.c b/drivers/tty/serial/mvebu-uart.c index ce362bd51de7..45b57c294d13 100644 --- a/drivers/tty/serial/mvebu-uart.c +++ b/drivers/tty/serial/mvebu-uart.c @@ -300,6 +300,8 @@ static int mvebu_uart_startup(struct uart_port *port) static void mvebu_uart_shutdown(struct uart_port *port) { writel(0, port->membase + UART_CTRL); + + free_irq(port->irq, port); } static void mvebu_uart_set_termios(struct uart_port *port, |