diff options
| author | Anton Vasilyev <vasilyev@ispras.ru> | 2018-07-24 19:11:27 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-09-26 08:36:32 +0200 |
| commit | d9f6ae2f49c8f614a877291a4e8a6a08c73a53c2 (patch) | |
| tree | df825771fcf3cb537535f3aaa26c458d272bc751 | |
| parent | 85d6635b637e395358aa87c4747cedbbed9d2dc1 (diff) | |
| download | linux-stable-d9f6ae2f49c8f614a877291a4e8a6a08c73a53c2.tar.gz linux-stable-d9f6ae2f49c8f614a877291a4e8a6a08c73a53c2.tar.bz2 linux-stable-d9f6ae2f49c8f614a877291a4e8a6a08c73a53c2.zip | |
video: goldfishfb: fix memory leak on driver remove
[ Upstream commit 5958fde72d04e7b8c6de3669d1f794a90997e3eb ]
goldfish_fb_probe() allocates memory for fb, but goldfish_fb_remove() does
not have deallocation of fb, which leads to memory leak on probe/remove.
The patch adds deallocation into goldfish_fb_remove().
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev <vasilyev@ispras.ru>
Cc: Aleksandar Markovic <aleksandar.markovic@mips.com>
Cc: Miodrag Dinic <miodrag.dinic@mips.com>
Cc: Goran Ferenc <goran.ferenc@mips.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/video/fbdev/goldfishfb.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/video/fbdev/goldfishfb.c b/drivers/video/fbdev/goldfishfb.c index 7f6c9e6cfc6c..14a93cb21310 100644 --- a/drivers/video/fbdev/goldfishfb.c +++ b/drivers/video/fbdev/goldfishfb.c @@ -301,6 +301,7 @@ static int goldfish_fb_remove(struct platform_device *pdev) dma_free_coherent(&pdev->dev, framesize, (void *)fb->fb.screen_base, fb->fb.fix.smem_start); iounmap(fb->reg_base); + kfree(fb); return 0; } |