summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMarco Felsch <m.felsch@pengutronix.de>2018-06-28 12:20:34 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-10-05 12:30:07 +0200
commitb0ff6664804ad6013b726252837ed38146b8a7e1 (patch)
tree848609354db34578554efaa87568870cea099240
parentc58ff323931ffb8b1ae423392dce7c21c7f2bfba (diff)
downloadlinux-stable-b0ff6664804ad6013b726252837ed38146b8a7e1.tar.gz
linux-stable-b0ff6664804ad6013b726252837ed38146b8a7e1.tar.bz2
linux-stable-b0ff6664804ad6013b726252837ed38146b8a7e1.zip
media: tvp5150: fix switch exit in set control handler
commit 2d29bcc8c237874795175b2930fa9a45a115175a upstream. The function only consists of a single switch case block without a default case. Unsupported control requests are indicated by the -EINVAL return code trough the last return statement at the end of the function. So exiting just the switch case block returns the -EINVAL error code but the hue control is supported and a zero should be returned instead. Replace the break by a 'return 0' to fix this behaviour. Fixes: d183e4efcae8 ("[media] v4l: tvp5150: Add missing break in set control handler") Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/media/i2c/tvp5150.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
index e83f8111a5fb..b27362ae4a5e 100644
--- a/drivers/media/i2c/tvp5150.c
+++ b/drivers/media/i2c/tvp5150.c
@@ -824,7 +824,7 @@ static int tvp5150_s_ctrl(struct v4l2_ctrl *ctrl)
return 0;
case V4L2_CID_HUE:
tvp5150_write(sd, TVP5150_HUE_CTL, ctrl->val);
- break;
+ return 0;
case V4L2_CID_TEST_PATTERN:
decoder->enable = ctrl->val ? false : true;
tvp5150_selmux(sd);