summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlaa Hleihel <alaa@mellanox.com>2020-04-13 16:22:35 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2020-05-05 19:14:39 +0200
commit7fbf5316b9ea1d4bf562e7f2e9f6bd6e3c00908c (patch)
treecc15c017f75fa6dea312670ba27c1c1393036048
parent779bb3625fed4a065a8b2a65323e287a475afba1 (diff)
downloadlinux-stable-7fbf5316b9ea1d4bf562e7f2e9f6bd6e3c00908c.tar.gz
linux-stable-7fbf5316b9ea1d4bf562e7f2e9f6bd6e3c00908c.tar.bz2
linux-stable-7fbf5316b9ea1d4bf562e7f2e9f6bd6e3c00908c.zip
RDMA/mlx4: Initialize ib_spec on the stack
commit c08cfb2d8d78bfe81b37cc6ba84f0875bddd0d5c upstream. Initialize ib_spec on the stack before using it, otherwise we will have garbage values that will break creating default rules with invalid parsing error. Fixes: a37a1a428431 ("IB/mlx4: Add mechanism to support flow steering over IB links") Link: https://lore.kernel.org/r/20200413132235.930642-1-leon@kernel.org Signed-off-by: Alaa Hleihel <alaa@mellanox.com> Reviewed-by: Maor Gottlieb <maorg@mellanox.com> Signed-off-by: Leon Romanovsky <leonro@mellanox.com> Signed-off-by: Jason Gunthorpe <jgg@mellanox.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/infiniband/hw/mlx4/main.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers/infiniband/hw/mlx4/main.c
index adc46b809ef2..0555c939c948 100644
--- a/drivers/infiniband/hw/mlx4/main.c
+++ b/drivers/infiniband/hw/mlx4/main.c
@@ -1589,8 +1589,9 @@ static int __mlx4_ib_create_default_rules(
int i;
for (i = 0; i < ARRAY_SIZE(pdefault_rules->rules_create_list); i++) {
+ union ib_flow_spec ib_spec = {};
int ret;
- union ib_flow_spec ib_spec;
+
switch (pdefault_rules->rules_create_list[i]) {
case 0:
/* no rule */