diff options
| author | Lv Yunlong <lyl2019@mail.ustc.edu.cn> | 2021-03-10 22:46:36 -0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-04-07 12:05:39 +0200 |
| commit | 0e42d5a5b3142a34e3243136bc75334d83b209c4 (patch) | |
| tree | fd8e4549e967fe0557714bae539f5a75aecd940f | |
| parent | cf5793c059ffb9c6e84d104edd2c26b36a417700 (diff) | |
| download | linux-stable-0e42d5a5b3142a34e3243136bc75334d83b209c4.tar.gz linux-stable-0e42d5a5b3142a34e3243136bc75334d83b209c4.tar.bz2 linux-stable-0e42d5a5b3142a34e3243136bc75334d83b209c4.zip | |
scsi: st: Fix a use after free in st_open()
[ Upstream commit c8c165dea4c8f5ad67b1240861e4f6c5395fa4ac ]
In st_open(), if STp->in_use is true, STp will be freed by
scsi_tape_put(). However, STp is still used by DEBC_printk() after. It is
better to DEBC_printk() before scsi_tape_put().
Link: https://lore.kernel.org/r/20210311064636.10522-1-lyl2019@mail.ustc.edu.cn
Acked-by: Kai Mäkisara <kai.makisara@kolumbus.fi>
Signed-off-by: Lv Yunlong <lyl2019@mail.ustc.edu.cn>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/scsi/st.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c index 618422ea3a41..0d58227431e4 100644 --- a/drivers/scsi/st.c +++ b/drivers/scsi/st.c @@ -1267,8 +1267,8 @@ static int st_open(struct inode *inode, struct file *filp) spin_lock(&st_use_lock); if (STp->in_use) { spin_unlock(&st_use_lock); - scsi_tape_put(STp); DEBC_printk(STp, "Device already in use.\n"); + scsi_tape_put(STp); return (-EBUSY); } |