diff options
| author | Du Cheng <ducheng2@gmail.com> | 2021-04-08 00:27:56 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-04-16 11:59:09 +0200 |
| commit | 8b334cdb7c4e6017d58bc9d015b69ab80bddfcc9 (patch) | |
| tree | b9f8a88ce5ff25c30f1a1651892427a94bd936cc | |
| parent | fe9e15a30be666ec8071f325a39fe13e2251b51d (diff) | |
| download | linux-stable-8b334cdb7c4e6017d58bc9d015b69ab80bddfcc9.tar.gz linux-stable-8b334cdb7c4e6017d58bc9d015b69ab80bddfcc9.tar.bz2 linux-stable-8b334cdb7c4e6017d58bc9d015b69ab80bddfcc9.zip | |
cfg80211: remove WARN_ON() in cfg80211_sme_connect
commit 1b5ab825d9acc0f27d2f25c6252f3526832a9626 upstream.
A WARN_ON(wdev->conn) would trigger in cfg80211_sme_connect(), if multiple
send_msg(NL80211_CMD_CONNECT) system calls are made from the userland, which
should be anticipated and handled by the wireless driver. Remove this WARN_ON()
to prevent kernel panic if kernel is configured to "panic_on_warn".
Bug reported by syzbot.
Reported-by: syzbot+5f9392825de654244975@syzkaller.appspotmail.com
Signed-off-by: Du Cheng <ducheng2@gmail.com>
Link: https://lore.kernel.org/r/20210407162756.6101-1-ducheng2@gmail.com
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | net/wireless/sme.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/wireless/sme.c b/net/wireless/sme.c index 6fd24f6435c3..ce6823646f63 100644 --- a/net/wireless/sme.c +++ b/net/wireless/sme.c @@ -512,7 +512,7 @@ static int cfg80211_sme_connect(struct wireless_dev *wdev, cfg80211_sme_free(wdev); } - if (WARN_ON(wdev->conn)) + if (wdev->conn) return -EINPROGRESS; wdev->conn = kzalloc(sizeof(*wdev->conn), GFP_KERNEL); |