summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorXiao Yang <yangx.jy@fujitsu.com>2022-04-10 19:35:13 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2022-06-14 16:52:36 +0200
commit6b6bd9e1f0855c7f717d90a657beebdb2213e679 (patch)
treea177d39bf9d96483624ec9f129349405a66c26eb
parent9af670b08007d2dd1a4acbdf700bc93615f3d0c2 (diff)
downloadlinux-stable-6b6bd9e1f0855c7f717d90a657beebdb2213e679.tar.gz
linux-stable-6b6bd9e1f0855c7f717d90a657beebdb2213e679.tar.bz2
linux-stable-6b6bd9e1f0855c7f717d90a657beebdb2213e679.zip
RDMA/rxe: Generate a completion for unsupported/invalid opcode
commit 2f917af777011c88e977b9b9a5d00b280d3a59ce upstream. Current rxe_requester() doesn't generate a completion when processing an unsupported/invalid opcode. If rxe driver doesn't support a new opcode (e.g. RDMA Atomic Write) and RDMA library supports it, an application using the new opcode can reproduce this issue. Fix the issue by calling "goto err;". Fixes: 8700e3e7c485 ("Soft RoCE driver") Link: https://lore.kernel.org/r/20220410113513.27537-1-yangx.jy@fujitsu.com Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/infiniband/sw/rxe/rxe_req.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/infiniband/sw/rxe/rxe_req.c b/drivers/infiniband/sw/rxe/rxe_req.c
index 463c4b3e7366..4553bed5353e 100644
--- a/drivers/infiniband/sw/rxe/rxe_req.c
+++ b/drivers/infiniband/sw/rxe/rxe_req.c
@@ -677,7 +677,7 @@ next_wqe:
opcode = next_opcode(qp, wqe, wqe->wr.opcode);
if (unlikely(opcode < 0)) {
wqe->status = IB_WC_LOC_QP_OP_ERR;
- goto exit;
+ goto err;
}
mask = rxe_opcode[opcode].mask;