diff options
| author | Julia Lawall <Julia.Lawall@inria.fr> | 2020-09-20 13:26:24 +0200 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab+huawei@kernel.org> | 2020-09-27 11:30:13 +0200 |
| commit | 8cc72b9c706bc30e5314130bedc07e40497e9f67 (patch) | |
| tree | c5e03ac276b1732cc7549ef00bd0527ef73b0e44 | |
| parent | b28e32798c78a346788d412f1958f36bb760ec03 (diff) | |
| download | linux-stable-8cc72b9c706bc30e5314130bedc07e40497e9f67.tar.gz linux-stable-8cc72b9c706bc30e5314130bedc07e40497e9f67.tar.bz2 linux-stable-8cc72b9c706bc30e5314130bedc07e40497e9f67.zip | |
media: saa7146: drop double zeroing
sg_init_table zeroes its first argument, so the allocation of that argument
doesn't have to.
the semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression x,n,flags;
@@
x =
- kcalloc
+ kmalloc_array
(n,sizeof(struct scatterlist),flags)
...
sg_init_table(x,n)
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
| -rw-r--r-- | drivers/media/common/saa7146/saa7146_core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/common/saa7146/saa7146_core.c b/drivers/media/common/saa7146/saa7146_core.c index 6b06ea590074..21fb16cc5ca1 100644 --- a/drivers/media/common/saa7146/saa7146_core.c +++ b/drivers/media/common/saa7146/saa7146_core.c @@ -140,7 +140,7 @@ static struct scatterlist* vmalloc_to_sg(unsigned char *virt, int nr_pages) struct page *pg; int i; - sglist = kcalloc(nr_pages, sizeof(struct scatterlist), GFP_KERNEL); + sglist = kmalloc_array(nr_pages, sizeof(struct scatterlist), GFP_KERNEL); if (NULL == sglist) return NULL; sg_init_table(sglist, nr_pages); |