summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMiaoqian Lin <linmq006@gmail.com>2022-06-03 18:02:44 +0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2022-06-22 14:13:19 +0200
commit57901c658f77d9ea2e772f35cb38e47efb54c558 (patch)
treee21cfd9832cb89ea7ba5e156358d35378cc92262
parenta44a8a762f7fe9ad3c065813d058e835a6180cb2 (diff)
downloadlinux-stable-57901c658f77d9ea2e772f35cb38e47efb54c558.tar.gz
linux-stable-57901c658f77d9ea2e772f35cb38e47efb54c558.tar.bz2
linux-stable-57901c658f77d9ea2e772f35cb38e47efb54c558.zip
usb: gadget: lpc32xx_udc: Fix refcount leak in lpc32xx_udc_probe
commit 4757c9ade34178b351580133771f510b5ffcf9c8 upstream. of_parse_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. of_node_put() will check NULL pointer. Fixes: 24a28e428351 ("USB: gadget driver for LPC32xx") Cc: stable <stable@kernel.org> Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Link: https://lore.kernel.org/r/20220603140246.64529-1-linmq006@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/usb/gadget/udc/lpc32xx_udc.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/usb/gadget/udc/lpc32xx_udc.c b/drivers/usb/gadget/udc/lpc32xx_udc.c
index 3f1c62adce4b..314cb5ea061a 100644
--- a/drivers/usb/gadget/udc/lpc32xx_udc.c
+++ b/drivers/usb/gadget/udc/lpc32xx_udc.c
@@ -3015,6 +3015,7 @@ static int lpc32xx_udc_probe(struct platform_device *pdev)
}
udc->isp1301_i2c_client = isp1301_get_client(isp1301_node);
+ of_node_put(isp1301_node);
if (!udc->isp1301_i2c_client) {
return -EPROBE_DEFER;
}