diff options
| author | Miaoqian Lin <linmq006@gmail.com> | 2022-05-24 11:45:17 +0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-06-29 08:59:52 +0200 |
| commit | 501652a2ad5450b4908e1f204ce75b2414c305b7 (patch) | |
| tree | 761fdb0f591313fd17353b7e718ffb7f33126aa1 | |
| parent | d40514d4403a89e00c17815140b3ec74d8ddd9b6 (diff) | |
| download | linux-stable-501652a2ad5450b4908e1f204ce75b2414c305b7.tar.gz linux-stable-501652a2ad5450b4908e1f204ce75b2414c305b7.tar.bz2 linux-stable-501652a2ad5450b4908e1f204ce75b2414c305b7.zip | |
iio: adc: adi-axi-adc: Fix refcount leak in adi_axi_adc_attach_client
commit ada7b0c0dedafd7d059115adf49e48acba3153a8 upstream.
of_parse_phandle() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.
Fixes: ef04070692a2 ("iio: adc: adi-axi-adc: add support for AXI ADC IP core")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220524074517.45268-1-linmq006@gmail.com
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/iio/adc/adi-axi-adc.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/iio/adc/adi-axi-adc.c b/drivers/iio/adc/adi-axi-adc.c index 9109da2d2e15..cbe1011a2408 100644 --- a/drivers/iio/adc/adi-axi-adc.c +++ b/drivers/iio/adc/adi-axi-adc.c @@ -334,16 +334,19 @@ static struct adi_axi_adc_client *adi_axi_adc_attach_client(struct device *dev) if (!try_module_get(cl->dev->driver->owner)) { mutex_unlock(®istered_clients_lock); + of_node_put(cln); return ERR_PTR(-ENODEV); } get_device(cl->dev); cl->info = info; mutex_unlock(®istered_clients_lock); + of_node_put(cln); return cl; } mutex_unlock(®istered_clients_lock); + of_node_put(cln); return ERR_PTR(-EPROBE_DEFER); } |