diff options
| author | Nicolas Toromanoff <nicolas.toromanoff@foss.st.com> | 2021-11-30 08:54:56 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-01-27 10:53:55 +0100 |
| commit | 5deb24e50372357cf975e85067f09a57ad33dc99 (patch) | |
| tree | 9396dfb76b209d59a384c43977595b9487517c4d | |
| parent | e9e0dd5da8ca4623e30ab1abd67882ddcda05050 (diff) | |
| download | linux-stable-5deb24e50372357cf975e85067f09a57ad33dc99.tar.gz linux-stable-5deb24e50372357cf975e85067f09a57ad33dc99.tar.bz2 linux-stable-5deb24e50372357cf975e85067f09a57ad33dc99.zip | |
crypto: stm32/cryp - fix xts and race condition in crypto_engine requests
[ Upstream commit d703c7a994ee34b7fa89baf21631fca0aa9f17fc ]
Don't erase key:
If key is erased before the crypto_finalize_.*_request() call, some
pending process will run with a key={ 0 }.
Moreover if the key is reset at end of request, it breaks xts chaining
mode, as for last xts block (in case input len is not a multiple of
block) a new AES request is started without calling again set_key().
Fixes: 9e054ec21ef8 ("crypto: stm32 - Support for STM32 CRYP crypto module")
Signed-off-by: Nicolas Toromanoff <nicolas.toromanoff@foss.st.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/crypto/stm32/stm32-cryp.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/crypto/stm32/stm32-cryp.c b/drivers/crypto/stm32/stm32-cryp.c index d13b262b3625..e2bcc4f98b0a 100644 --- a/drivers/crypto/stm32/stm32-cryp.c +++ b/drivers/crypto/stm32/stm32-cryp.c @@ -674,8 +674,6 @@ static void stm32_cryp_finish_req(struct stm32_cryp *cryp, int err) else crypto_finalize_skcipher_request(cryp->engine, cryp->req, err); - - memset(cryp->ctx->key, 0, cryp->ctx->keylen); } static int stm32_cryp_cpu_start(struct stm32_cryp *cryp) |