summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGeorge Cherian <george.cherian@marvell.com>2023-02-09 02:11:17 +0000
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2023-04-20 12:10:28 +0200
commit7b78445bce52ec0345cb7da1a9beaf47ffa8e9ea (patch)
tree883f1ba73ebe66055e5d4f86d4e0aeec9f6c42b1
parent10b7a33c5de3c3de27d497060d0a8b5da5b69546 (diff)
downloadlinux-stable-7b78445bce52ec0345cb7da1a9beaf47ffa8e9ea.tar.gz
linux-stable-7b78445bce52ec0345cb7da1a9beaf47ffa8e9ea.tar.bz2
linux-stable-7b78445bce52ec0345cb7da1a9beaf47ffa8e9ea.zip
watchdog: sbsa_wdog: Make sure the timeout programming is within the limits
commit 000987a38b53c172f435142a4026dd71378ca464 upstream. Make sure to honour the max_hw_heartbeat_ms while programming the timeout value to WOR. Clamp the timeout passed to sbsa_gwdt_set_timeout() to make sure the programmed value is within the permissible range. Fixes: abd3ac7902fb ("watchdog: sbsa: Support architecture version 1") Signed-off-by: George Cherian <george.cherian@marvell.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net> Link: https://lore.kernel.org/r/20230209021117.1512097-1-george.cherian@marvell.com Signed-off-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org> Signed-off-by: Tyler Hicks (Microsoft) <code@tyhicks.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/watchdog/sbsa_gwdt.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/watchdog/sbsa_gwdt.c b/drivers/watchdog/sbsa_gwdt.c
index f0f1e3b2e463..4cbe6ba52754 100644
--- a/drivers/watchdog/sbsa_gwdt.c
+++ b/drivers/watchdog/sbsa_gwdt.c
@@ -121,6 +121,7 @@ static int sbsa_gwdt_set_timeout(struct watchdog_device *wdd,
struct sbsa_gwdt *gwdt = watchdog_get_drvdata(wdd);
wdd->timeout = timeout;
+ timeout = clamp_t(unsigned int, timeout, 1, wdd->max_hw_heartbeat_ms / 1000);
if (action)
writel(gwdt->clk * timeout,