diff options
| author | Yang Li <yang.lee@linux.alibaba.com> | 2021-06-07 16:40:36 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-09-22 12:28:02 +0200 |
| commit | 4a933932033854fc7be495ed966e47a42132a8c4 (patch) | |
| tree | e5786281eec3820dee4769a6b1fc89495d57fedc | |
| parent | ce660d6dfcdd2836883673154835636438928929 (diff) | |
| download | linux-stable-4a933932033854fc7be495ed966e47a42132a8c4.tar.gz linux-stable-4a933932033854fc7be495ed966e47a42132a8c4.tar.bz2 linux-stable-4a933932033854fc7be495ed966e47a42132a8c4.zip | |
NTB: perf: Fix an error code in perf_setup_inbuf()
[ Upstream commit 0097ae5f7af5684f961a5f803ff7ad3e6f933668 ]
When the function IS_ALIGNED() returns false, the value of ret is 0.
So, we set ret to -EINVAL to indicate this error.
Clean up smatch warning:
drivers/ntb/test/ntb_perf.c:602 perf_setup_inbuf() warn: missing error
code 'ret'.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/ntb/test/ntb_perf.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/ntb/test/ntb_perf.c b/drivers/ntb/test/ntb_perf.c index 89df1350fefd..65e1e5cf1b29 100644 --- a/drivers/ntb/test/ntb_perf.c +++ b/drivers/ntb/test/ntb_perf.c @@ -598,6 +598,7 @@ static int perf_setup_inbuf(struct perf_peer *peer) return -ENOMEM; } if (!IS_ALIGNED(peer->inbuf_xlat, xlat_align)) { + ret = -EINVAL; dev_err(&perf->ntb->dev, "Unaligned inbuf allocated\n"); goto err_free_inbuf; } |