diff options
| author | Yang Li <yang.lee@linux.alibaba.com> | 2021-06-07 13:56:20 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-09-22 12:28:02 +0200 |
| commit | ce660d6dfcdd2836883673154835636438928929 (patch) | |
| tree | 1f0a0121000adc61e9f8ea42ddad36c33c9fa1fb | |
| parent | e76ccbdedbddaf14c65b50bbf2ffe8118958d15e (diff) | |
| download | linux-stable-ce660d6dfcdd2836883673154835636438928929.tar.gz linux-stable-ce660d6dfcdd2836883673154835636438928929.tar.bz2 linux-stable-ce660d6dfcdd2836883673154835636438928929.zip | |
NTB: Fix an error code in ntb_msit_probe()
[ Upstream commit 319f83ac98d7afaabab84ce5281a819a358b9895 ]
When the value of nm->isr_ctx is false, the value of ret is 0.
So, we set ret to -ENOMEM to indicate this error.
Clean up smatch warning:
drivers/ntb/test/ntb_msi_test.c:373 ntb_msit_probe() warn: missing
error code 'ret'.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/ntb/test/ntb_msi_test.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/ntb/test/ntb_msi_test.c b/drivers/ntb/test/ntb_msi_test.c index 7095ecd6223a..4e18e08776c9 100644 --- a/drivers/ntb/test/ntb_msi_test.c +++ b/drivers/ntb/test/ntb_msi_test.c @@ -369,8 +369,10 @@ static int ntb_msit_probe(struct ntb_client *client, struct ntb_dev *ntb) if (ret) goto remove_dbgfs; - if (!nm->isr_ctx) + if (!nm->isr_ctx) { + ret = -ENOMEM; goto remove_dbgfs; + } ntb_link_enable(ntb, NTB_SPEED_AUTO, NTB_WIDTH_AUTO); |