summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNicolas Saenz Julienne <nsaenz@kernel.org>2021-08-31 14:58:42 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2021-10-20 11:45:03 +0200
commit2d937cc12c140b2eb20cbb0fc8502d7232f18fe3 (patch)
treedbabfa137e09fe4b2a1d123d5272eda574b4187e
parent6e6082250b53d9125c06e82de8a1948fc345bfc8 (diff)
downloadlinux-stable-2d937cc12c140b2eb20cbb0fc8502d7232f18fe3.tar.gz
linux-stable-2d937cc12c140b2eb20cbb0fc8502d7232f18fe3.tar.bz2
linux-stable-2d937cc12c140b2eb20cbb0fc8502d7232f18fe3.zip
ARM: dts: bcm2711-rpi-4-b: Fix pcie0's unit address formatting
commit 13dbc954b3c9a9de0ad5b7279e8d3b708d31068b upstream. dtbs_check currently complains that: arch/arm/boot/dts/bcm2711-rpi-4-b.dts:220.10-231.4: Warning (pci_device_reg): /scb/pcie@7d500000/pci@1,0: PCI unit address format error, expected "0,0" Unsurprisingly pci@0,0 is the right address, as illustrated by its reg property: &pcie0 { pci@0,0 { /* * As defined in the IEEE Std 1275-1994 document, * reg is a five-cell address encoded as (phys.hi * phys.mid phys.lo size.hi size.lo). phys.hi * should contain the device's BDF as 0b00000000 * bbbbbbbb dddddfff 00000000. The other cells * should be zero. */ reg = <0 0 0 0 0>; }; }; The device is clearly 0. So fix it. Also add a missing 'device_type = "pci"'. Fixes: 258f92d2f840 ("ARM: dts: bcm2711: Add reset controller to xHCI node") Suggested-by: Rob Herring <robh@kernel.org> Reviewed-by: Rob Herring <robh@kernel.org> Link: https://lore.kernel.org/r/20210831125843.1233488-1-nsaenzju@redhat.com Signed-off-by: Nicolas Saenz Julienne <nsaenz@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--arch/arm/boot/dts/bcm2711-rpi-4-b.dts3
1 files changed, 2 insertions, 1 deletions
diff --git a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
index 76de029c588a..167538518a1e 100644
--- a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
+++ b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
@@ -255,7 +255,8 @@
};
&pcie0 {
- pci@1,0 {
+ pci@0,0 {
+ device_type = "pci";
#address-cells = <3>;
#size-cells = <2>;
ranges;