diff options
| author | Christian König <christian.koenig@amd.com> | 2021-04-23 14:28:51 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-04-28 13:41:47 +0200 |
| commit | 99e396d86582e4be02c717e93126de5d83f7b8a6 (patch) | |
| tree | 1f403a56bb93d4a46a172ae11eac08a9244ef713 | |
| parent | f65c0fdb7db2750677bf2cb53e62d7d205c20ab5 (diff) | |
| download | linux-stable-99e396d86582e4be02c717e93126de5d83f7b8a6.tar.gz linux-stable-99e396d86582e4be02c717e93126de5d83f7b8a6.tar.bz2 linux-stable-99e396d86582e4be02c717e93126de5d83f7b8a6.zip | |
coda: fix reference counting in coda_file_mmap error path
commit 9da29c7f77cd04e5c9150e30f047521b6f20a918 upstream.
mmap_region() now calls fput() on the vma->vm_file.
So we need to drop the extra reference on the coda file instead of the
host file.
Link: https://lkml.kernel.org/r/20210421132012.82354-1-christian.koenig@amd.com
Fixes: 1527f926fd04 ("mm: mmap: fix fput in error path v2")
Signed-off-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Acked-by: Jan Harkes <jaharkes@cs.cmu.edu>
Cc: Miklos Szeredi <miklos@szeredi.hu>
Cc: Jason Gunthorpe <jgg@ziepe.ca>
Cc: <stable@vger.kernel.org> [5.11+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | fs/coda/file.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/fs/coda/file.c b/fs/coda/file.c index 128d63df5bfb..ef5ca22bfb3e 100644 --- a/fs/coda/file.c +++ b/fs/coda/file.c @@ -175,10 +175,10 @@ coda_file_mmap(struct file *coda_file, struct vm_area_struct *vma) ret = call_mmap(vma->vm_file, vma); if (ret) { - /* if call_mmap fails, our caller will put coda_file so we - * should drop the reference to the host_file that we got. + /* if call_mmap fails, our caller will put host_file so we + * should drop the reference to the coda_file that we got. */ - fput(host_file); + fput(coda_file); kfree(cvm_ops); } else { /* here we add redirects for the open/close vm_operations */ |