diff options
| author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2020-04-06 20:10:03 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2020-04-07 10:43:43 -0700 |
| commit | 842ae1f52b44a4fa3e4e7e5dd61e8b53e8a09ece (patch) | |
| tree | a4337052eccb94f01f54482c4c3257fc5292f8e4 | |
| parent | c6e2ac3b476b458f9bd2069d85b95ca4634ce680 (diff) | |
| download | linux-stable-842ae1f52b44a4fa3e4e7e5dd61e8b53e8a09ece.tar.gz linux-stable-842ae1f52b44a4fa3e4e7e5dd61e8b53e8a09ece.tar.bz2 linux-stable-842ae1f52b44a4fa3e4e7e5dd61e8b53e8a09ece.zip | |
lib/ts_fsm.c: replace zero-length array with flexible-array member
The current codebase makes use of the zero-length array language extension
to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:
struct foo {
int stuff;
struct boo array[];
};
By making use of the mechanism above, we will get a compiler warning in
case the flexible array does not occur last in the structure, which will
help us prevent some kind of undefined behavior bugs from being
inadvertenly introduced[3] to the codebase from now on.
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Link: http://lkml.kernel.org/r/20200211205813.GA25602@embeddedor
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rw-r--r-- | lib/ts_fsm.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/ts_fsm.c b/lib/ts_fsm.c index 9c873cadab7c..ab749ec10ab5 100644 --- a/lib/ts_fsm.c +++ b/lib/ts_fsm.c @@ -32,7 +32,7 @@ struct ts_fsm { unsigned int ntokens; - struct ts_fsm_token tokens[0]; + struct ts_fsm_token tokens[]; }; /* other values derived from ctype.h */ |