diff options
| author | Vitaly Kuznetsov <vkuznets@redhat.com> | 2018-10-16 18:50:05 +0200 |
|---|---|---|
| committer | Paolo Bonzini <pbonzini@redhat.com> | 2018-10-17 00:30:17 +0200 |
| commit | 12e0c6186ba44bb6194cf5d2eda8f46880126587 (patch) | |
| tree | a1196741480d99d3b6ae449e0bf679e8650b5da0 | |
| parent | c4ebd6295ab730bf922c96d3c4045c3a84fd1cf7 (diff) | |
| download | linux-stable-12e0c6186ba44bb6194cf5d2eda8f46880126587.tar.gz linux-stable-12e0c6186ba44bb6194cf5d2eda8f46880126587.tar.bz2 linux-stable-12e0c6186ba44bb6194cf5d2eda8f46880126587.zip | |
x86/kvm/hyperv: don't clear VP assist pages on init
VP assist pages may hold valuable data which needs to be preserved across
migration. Clean PV EOI portion of the data on init, the guest is
responsible for making sure there's no garbage in the rest.
This will be used for nVMX migration, eVMCS address needs to be preserved.
Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
| -rw-r--r-- | arch/x86/kvm/hyperv.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/arch/x86/kvm/hyperv.c b/arch/x86/kvm/hyperv.c index d9b7b4cd4e43..4e80080f277a 100644 --- a/arch/x86/kvm/hyperv.c +++ b/arch/x86/kvm/hyperv.c @@ -1104,7 +1104,13 @@ static int kvm_hv_set_msr(struct kvm_vcpu *vcpu, u32 msr, u64 data, bool host) addr = kvm_vcpu_gfn_to_hva(vcpu, gfn); if (kvm_is_error_hva(addr)) return 1; - if (__clear_user((void __user *)addr, PAGE_SIZE)) + + /* + * Clear apic_assist portion of f(struct hv_vp_assist_page + * only, there can be valuable data in the rest which needs + * to be preserved e.g. on migration. + */ + if (__clear_user((void __user *)addr, sizeof(u32))) return 1; hv_vcpu->hv_vapic = data; kvm_vcpu_mark_page_dirty(vcpu, gfn); |